This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[file_selector] Switch to Pigeon for macOS#6902
Merged
auto-submit[bot] merged 6 commits intoflutter:mainfrom Jan 10, 2023
Merged
[file_selector] Switch to Pigeon for macOS#6902auto-submit[bot] merged 6 commits intoflutter:mainfrom
auto-submit[bot] merged 6 commits intoflutter:mainfrom
Conversation
tarrinneal
reviewed
Jan 3, 2023
Contributor
tarrinneal
left a comment
There was a problem hiding this comment.
This all seems good to me. I want to have @cbracken give final approval though.
packages/file_selector/file_selector_macos/test/file_selector_macos_test.mocks.dart
Show resolved
Hide resolved
4 tasks
tarrinneal
approved these changes
Jan 10, 2023
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts from direct method channel use to the new experimental Swift generator.
Some specific changes to call out that aren't just direct conversion:
NSOpenPanelandNSSavePanel, in support of the general goal of preferring to have logic in Dart.This is a particularly strong case for a Pigeon conversion since we don't currently have a way to run integration tests for this plugin, so the Dart/Swift communication layer isn't tested, making the plugin prone to bugs where each side's unit tests pass, but the plugin doesn't actually work because of an API expectation mismatch. This offloads exactly that otherwise untested part to Pigeon, which has its own set of tests of that layer.
(The native unit tests are a little more verbose since we don't have a way to provide default values for data classes currently, but that's a small downside relative to the benefits.)
Part of flutter/flutter#117844
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).